On 2021/01/29 0:27, Johan Corveleyn wrote:
> On Thu, Jan 28, 2021 at 4:22 PM Yasuhito FUTATSUKI
> <futat...@yf.bsdclub.org> wrote:
>>
>> On 2021/01/28 20:13, Johan Corveleyn wrote:
>>> On Thu, Jan 28, 2021 at 12:55 AM Yasuhito FUTATSUKI
>>> <futat...@yf.bsdclub.org> wrote:
>>>>
>>>> On 2021/01/28 7:33, Johan Corveleyn wrote:
>>>>> On Wed, Jan 27, 2021 at 10:19 PM Yasuhito FUTATSUKI
>>>>> <futat...@yf.bsdclub.org> wrote:
>>>>>>
>>>>>> On 2021/01/28 5:43, Johan Corveleyn wrote:
>>>>>>> On Mon, Mar 16, 2020 at 5:11 AM <james...@apache.org> wrote:
>>>>
>>>>
>>>>>>> [[[
>>>>>>> C:\test>set EDITOR="C:\Program Files\Notepad++\notepad++" -nosession
>>>>>>> -multiInst
>>>>>>>
>>>>>>> C:\test>svn pe svn:ignore .
>>>>>>> 'C:\Program' is not recognized as an internal or external command,
>>>>>>> operable program or batch file.
>>>>>>> svn: E200012: system('"C:\Program Files\Notepad++\notepad++"
>>>>>>> -nosession -multiInst "svn-prop.tmp"') returned 1
>>>>>>> ]]]
>>>>>>
>>>>>> Perhaps my pending patch also fix this.
>>>>>>
>>>>>> Please see
>>>>>>
>>>>>> https://lists.apache.org/thread.html/r2b8b0b4ca0f833e371590fadb33ee24c6335127e967664c6e612e154%40%3Cdev.subversion.apache.org%3E
>>>>>>
>>>>>> and attached patch
>>>>>>
>>>>>> https://lists.apache.org/api/email.lua?attachment=true&id=r2b8b0b4ca0f833e371590fadb33ee24c6335127e967664c6e612e154@%3Cdev.subversion.apache.org%3E&file=d76c6fedb56414d73e0d481910f7e62bde6d0582e975c4b2134c8521b5f9e30f
>>>>>
>>>>> Yes indeed, that seems to fix it :). Nice!
>>>>>
>>>>> Is anything holding this patch back from being committed? We're mainly
>>>>> a CTR - Commit Then Review - project, so if you feel okay about it ...
>>>>> I haven't studied it in depth, but on a cursory look, it seems fine to
>>>>> me (and it works / fixes my problem, yay!).
>>>> Then I commited it in r1885953, with minor fix in comment.
>>>
>>> Great!
>>>
>>> I took the liberty to nominate it (with my vote) for 1.14.x, not in
>>> the least because I'm personally affected by this (always a good
>>> motivation :-)). Not sure if it'll gather enough votes in time to make
>>> it into 1.14.1, but it doesn't hurt to try :-).
>>
>> Unfortunately this causes conflict on 1.14.x because it depends on r1882234.
>
> Argh, sorry should have noticed that. Hmmm.>
> Should I withdraw the nomination? Or should I add r1882234 to it? I
> don't know the context of these revisions very well ...
I don't think you need to withdraw it.
This series of the changes of subversion/libsvn_subr/cmdline.c addressed
the issues on editor invocation on non UTF-8 locale including Windows,
both in the editor path and a target file name which contains non ascii
characters. A fix of issue on editor path containing white space on
Windows is a side effect; I also checked in such a case :)
So if r1882234 is also backported, it can be also possible to invoke
editor on conflict even if the target file name contains emoji on Windows,
or on non UTF-8 locale on Unix/Linux. (I used "🍣.txt" to check it :))
Cheers,
--
Yasuhito FUTATSUKI <futat...@yf.bsclub.org>
