On Thu, Jan 28, 2021 at 1:15 AM Alexandr Miloslavskiy <alexandr.miloslavs...@syntevo.com> wrote: > > On 27.01.2021 13:00, Johan Corveleyn wrote: > > > ^^ some lines indented with tabs instead of spaces > > > ^^ curly brace should be on next line > > > ^^ The comment above, describing how the JVM crashes, refers to the > > situation before you actually fixed that :-). Can you rephrase it a > > bit, so it is still applicable even with the crash now fixed? > > > ^^ same here, the comments describe the behavior before the fix, maybe > > rephrase it so it's still valid after you fixed it. > > Thanks, I fixed everything in r1885955.
Thanks. I see you did a bit more than what I mentioned above (I guess you did a "reformat" of the entire section you added), but that's fine of course (I only spotted a couple of tidbits, not everything :)). With that, the branch looks good to me, and I think we should merge this to trunk, and then nominate it (the merge-to-trunk commit I guess) for backport to 1.14 (concretely, this means adding an entry to 1.14.x/STATUS [1]). @Alexandr: would you like to do the honors? First to merge your branch to trunk, and after that to add a corresponding section to 1.14.x/STATUS? In fact: please consider your partial committership (javahl bindings) now to be no longer confined to branches. Feel free to perform commits to the javahl bindings area also on trunk (which includes the above merge of course). This also means you have a binding vote on backport proposals related to the javahl bindings. [1] https://svn.apache.org/repos/asf/subversion/branches/1.14.x/STATUS -- Johan
