On 22.11.2020 11:39, Yasuhito FUTATSUKI wrote:
On 2020/11/22 18:24, Yasuhito FUTATSUKI wrote:
On 2020/11/22 17:54, Branko Čibej wrote:
On 22.11.2020 08:24, futat...@apache.org wrote:
Author: futatuki
Date: Sun Nov 22 07:24:46 2020
New Revision: 1883719
URL: http://svn.apache.org/viewvc?rev=1883719&view=rev
Log:
Reduce macro expansion, no functional change.
* build/ac-macros/swig.m4
everywhere: Remove trailing whitespaces.
(SVN_CHECK_SWIG): Gather the use of SVN_FIND_SWIG by using cache variable.
(SVN_CHECK_SWIG, SVN_FIND_SWIG): Remove unused variable SWIG_SUITABLE.
Modified:
subversion/trunk/build/ac-macros/swig.m4
This commit causes a failure on the warnings buildbot:
https://ci.apache.org/builders/svn-warnings/builds/3186/steps/Configure/logs/stdio
Swig should not be "required" if it's not mentioned in configure options.
Ah, I overlooked the usage of value 'check' for the argument 'where'.
I restored the usage of this in r1883722. Thank you.
Also, I'll change this behavor to warn only if users correctly specified some
of --with-swig-* but swig is not found in "release mode".
^non
It is an obvious mistake, but just to make sure.
+1
