On 2020/11/13 23:26, Nathan Hartman wrote: > On Fri, Nov 13, 2020 at 2:06 AM Yasuhito FUTATSUKI > <futat...@yf.bsdclub.org> wrote: >> This looks good to me. Thank you very much. > > Committed the release-notes/1.14.html fix in r1883386. > >> I think it is better if this note is included in the swig bindings >> INSTALL file. (Yes, I overlooked when I commit r1876662.) > > Please could you add this note there?
Yes, here is a draft, however I think it needs reviews. [[[ * subversion/bindings/swig/INSTALL (STEP 2): Add the case users want to use the language bindings C source shipped with the distribution tarball. (BUILDING SWIG BINDINGS FOR SVN ON WINDOWS 3.): Replace version number of SWIG in its path in examples. Index: subversion/bindings/swig/INSTALL =================================================================== --- subversion/bindings/swig/INSTALL (revision 1883337) +++ subversion/bindings/swig/INSTALL (working copy) @@ -141,7 +141,15 @@ See Subversion's own INSTALL file for details. - Make sure that Subversion's ./configure script sees your installed SWIG! + If you are using the distribution tarball and you want to use the language + bindings C source files shipped with it, you might need to pass the + --without-swig option to configure script to avoid detecting and checking + SWIG on your system. A Makefile generated by configure will prevent + building the language bindings if the configure script detect unsuitable + version of SWIG. + + Otherwise, if you want to generate bindings C source files by using SWIG, + make sure that Subversion's ./configure script sees your installed SWIG! It tries to detect SWIG near the very end of its output. You can find it by running 'grep "^SWIG=" config.log'. @@ -295,11 +303,11 @@ the --with-swig parameter to the installed location for SWIG. Example: - > gen-make.py <other options> --with-swig="C:\Program Files\SWIG-2.0.2" + > gen-make.py <other options> --with-swig="C:\Program Files\SWIG-4.0.2" If you are building python bindings, point to the py3c directory as well: - > gen-make.py <other options> --with-swig="C:\Program Files\SWIG-2.0.2" \ + > gen-make.py <other options> --with-swig="C:\Program Files\SWIG-4.0.2" \ --with-py3c="C:\SVN\py3c" 4. If you haven't already built Subversion, you should do so now. ]]] > Also, nominate for backport, since users of 1.14.1 will probably look > there for answers... Yes, I will. > > Thanks! > Nathan > Cheers, -- Yasuhito FUTATSUKI <futat...@yf.bsclub.org>