Yasuhito FUTATSUKI wrote on Wed, 30 Sep 2020 01:08 +00:00: > I also confirmed it occured in svn_fs_fs.is_packed_rev(). > > Perhaps SvnContentProxy object also keep fsroot object until the > stream is closed. I found a note in docstring for svn_fs_file_contents(): > > """ > * @todo kff: I am worried about lifetime issues with this pool vs > * the trail created farther down the call stack. Trace this function > * to investigate... > """ >
For avoidance of doubt, "trail" is a libsvn_fs_base concept, so the concern described in the comment may or may not be applicable to the svn_fs_fs__is_packed_rev() case. Furthermore, I think this comment was written long before FSFS packing was created. "kff" is kfogel@. > I worry about the svn_stream_t * object returned by svn_fs_file_contents() > depends that svn_fs_root_t * root is living. Cheers, Daniel
