On 17.06.2020 11:41, Tobias Bading wrote: > Hi Brane. > > On 17.06.2020 07:02, Branko Čibej wrote: >> […] >> r1878909; there were a number of other problems with that code, so I >> added unit tests as well. > Thanks for your patch in r1878909. It merges cleanly into > ^/subversion/tags/1.14.0 and seems to work fine, including the new > filesize-test.c. > > Minor issues: > - the description of [filesize-test] in subversion/trunk/build.conf is > copy'n'pasta
Duh. I keep missing those. > - subversion/tests/client could use an svn:ignore for .libs and filesize-test Ah yes, I always build out-of-tree so I don't see those. > I’ve seen that you proposed the patch for 1.14.1 (and 1.13.x) in r1878910. > Maybe the incorrect output could be explained a bit, i.e. that the output in > B and KB was correct, but file sizes beyond that were exaggerated (greatly). It was incorrect in other ways too, for decimal exponents as well. -- Brane
