On 2020/03/13 21:53, Michael Pilato wrote: > One thing that appears to be different about this tarball than a typical > release tarball is the absence of the swig-generated wrapper files > (...python/svn_client.c, etc.). I'm going to take a crack at replicating > your release environment (the Debian VM, etc.), but is there a flag or > package or something that was omitted that would obviously have resulted in > the missing SWIG-generated files? >
As far as I read tools/dist/release.py, it runs "autogen.sh --release". However as I wrote before[1] it is need to specify SWIG_PY_OPTS shell/environment variable to generate SWIG Python bindings C source and support codes. The value of SWIG_PY_OPTS depends on which is its target py2 or py3, on which SWIG version is prior 4.0 or not. Anyway, release tarball cannot include py2 and py3 bindings source at the same time in current build system. So it is need to determine which is included in release tarball, before fix release.py (and/or autogen.sh). And if we want bundle both, we should modify build system to handle both of source files. One of propose to do so is a patch I posted before[2] (but as it require to rename support library for Python 2 bindings from libsvn_swig_py to libsvn_swig_py2, I don't commit it). [1] https://mail-archives.apache.org/mod_mbox/subversion-dev/201912.mbox/%3c5b691321-209a-fd38-cb0d-85e2f5bae...@poem.co.jp%3e [2] https://mail-archives.apache.org/mod_mbox/subversion-dev/201912.mbox/%3cac0c9f98-df80-cdf6-e9c3-234248359...@poem.co.jp%3e Cheers, -- Yasuhito FUTATSUKI <futat...@yf.bsdclub.org>/<futat...@poem.co.jp>
