On 2019/12/12 0:12, Julian Foad wrote:
Stefan Sperling wrote:
My first question would be: Could anyone could test this on Windows?
(Assuming you've been testing on Debian, as usual.)
My next question would be: What about all the other places we call out to the
shell? Do we already have some places that escape filenames even on Windows
(even if perfect escaping isn't possible there)? Is this place inconsistent
and could be fixed by making it work the same as everywhere else, for example,
or are they all broken, or what?
As far as I grep under subversion/ , they are the last places using
system(3) to create child process. In other places apr_proc* functions
are used and no 'APR_SHELLCMD' found, so it seems we don't use shell
there.
Cheers,
--
Yasuhito FUTATSUKI <futat...@yf.bsdclub.org>/<futat...@poem.co.jp>