On Thu, Nov 14, 2019 at 8:18 AM Jun Omae <[email protected]> wrote: > (Posting to dev list, again...) > > On Thu, Nov 14, 2019 at 1:47 AM Julian Foad <[email protected]> wrote: > > Perhaps someone could commit this if there are no other concerns with > > it, and adjust INSTALL at the same time? > > Updated proposed patch, including a change of > subversion/bindings/swig/INSTALL. >
Hi all, Jun, thank you for this patch. I would like to get this committed quickly if there are no objections, but this is not my area of expertise. Brane, do I understand correctly that you are satisfied with the results of your review/test? In particular, the main question I have is with regards to the -modern option being added for SWIG 3.x .. <4 with Py3. If I understand correctly, this changes the way SWIG will generate accessors (properties vs getters/setters). Would this break any downstream code? (And if so, is that acceptable?) Also I don't fully understand the last part of the patch: is it creating replacements for the aforementioned getters/setters? Thanks, Nathan
