Nathan Hartman wrote on Tue, Oct 29, 2019 at 11:11:58 -0400:
> [[[
> def finish(self):
⋮
> except smtplib.SMTPRecipientsRefused as detail:
> sys.stderr.write("mailer.py: SMTP recipient(s) refused: %s: %s\n"
> % (self.to_addrs, detail,))
> raise MessageSendFailure
Would «raise MessageSendFailure from detail» make sense here, and in the next
«except» case as well?
> Daniel, thank you for finding rzigweid's real name. I didn't know how
> to do that. :-)
You're welcome. For context, Subversion's homepage and issue tracker were both
at https://subversion.tigris.org/ for the first decade of the project's
existence. When we moved to ASF (between 1.6.0 and 1.7.0), we also migrated to
an ASF-hosted issue tracker to avoid the tigris.org bus factor risk. The old
issue tracker was then made read-only.
This is also related to the transition from svn.collab.net to svn.apache.org,
documented in ^/subversion/README (sic).
> I agree that the glob pattern in the log message is a bad idea as it reduces
> searchability. I've changed this to list each affected function explicitly.
Thanks. HACKING does document this explicitly, too.
Cheers,
Daniel
