On Fri, Oct 18, 2019 at 4:52 AM Branko Čibej <br...@apache.org> wrote:
> >> - print("SUMMARY: %s, by the grace of Python %d.%d.%d.\n"
> >> - % (summary,
> >> - sys.version_info.major,
> >> - sys.version_info.minor,
> >> - sys.version_info.micro))
> >> + print("Python version: %d.%d.%d.\n" % sys.version_info[:3])
> >> + print(summary)
> >>
> >> self._close_log()
> >> return failed
> > I don't object to the changed message, but I do object to the missing
> > prefix "SUMMARY: " on the last line and the missing additional newline
> > on the same last line and the extra newline on the python version line.
> >
> > Should be:
> > print("SUMMARY: %s\n" % summary)
> >
> > and remove the trailing newline from the Python version line.
>
Done in r1868596.
Looks like this:
$ make check TESTS=subversion/tests/cmdline/diff_tests.py
[1/1]
diff_tests.py......................................................success
Summary of test results:
1 test PASSED
Python version: 2.7.10.
SUMMARY: All tests successful
$
Have a nice day :-)
Nathan
