On Fri, Oct 11, 2019 at 2:38 PM Yasuhito FUTATSUKI <futat...@poem.co.jp> wrote: > > On 2019-09-30 06:32, Johan Corveleyn wrote: > ... > > At this point, I think the only thing blocking reintegration of this > > branch into trunk seems to be the C4115 warning / error. As I said, I > > have no informed opinion either way (and Brane was okay with turning > > it into a warning). So if Bert doesn't reply within a couple of days, > > I'd say we are good to go. > > ... and more than a week has past. So I've commited the patch address > to it on swig-py3 branch, as r1868290.
Great. I've retested it all on Windows (once with Python 2.7.16, and once with Python 3.7.4) and it looks good to me. +1 to reintegrate the branch into trunk. -- Johan
