Daniel Shahaf wrote:
In current master, «./autogen.sh && ./configure && make davautocheck» fails all 
svnmover tests.

By default, 'make davautocheck' expects to find 'tools/server-side/mod_dontdothat' has already been built; my first reaction then was to run 'make tools' which builds that and also builds 'svnmover', and the tests pass; but if I instead run 'make mod_dontdothat' then I see the problem.

make davautocheck
I think the following will fix it, but haven't verified:

Index: build/generator/gen_base.py
===================================================================
--- build/generator/gen_base.py (revision 1866222)
+++ build/generator/gen_base.py (working copy)
@@ -663,7 +663,7 @@ class TargetExe(TargetLinked):
      TargetLinked.add_dependencies(self)
# collect test programs
-    if 'svnauthz' in self.name: # special case
+    if 'svnauthz' in self.name or 'svnmover' in self.name: # special case
        self.gen_obj.test_deps.append(self.filename)
        self.gen_obj.test_helpers.append(self.filename)
      elif self.install == 'test':

Could someone please verify/commit?

Verified and committed: http://svn.apache.org/r1866281

Thanks for finding that.

- Julian


Reply via email to