On 12.04.2019 11:28, Stefan Sperling wrote: > On Wed, Apr 10, 2019 at 12:07:23AM +0200, Branko Čibej wrote: >> This is nonsense. We should replace the single use of >> SVN_APR_INT64_T_PYCFMT in swigutil_py.c with "L" and cast to >> PY_LONG_LONG and be done with it. Such checks will always have failing >> edge cases, so let's just get rid of them. > Agreed. See https://svn.apache.org/r1857391 Does this look good?
Better. Except that, IIRC, PY_LONG_LONG might not be defined on some platform/compiler combinations. On the other hand, we can fix that if and when someone reports it. The current change is already much better than what we tried doing before. -- Brane
