Yasuhito FUTATSUKI wrote on Sun, 17 Feb 2019 06:13 +00:00: > On 2/17/19 9:04 AM, Daniel Shahaf wrote: > > > I was wondering what are the blockers for merging swig-py3 into trunk? > > The only item in BRANCH-README is "Fix a compile error on windows with > > py3", but I don't even know if that's a current issue or an old one that has > > since been fixed. > > I'm sorry I'm not sure the compile error still exists or not. (I don't > have Windows build environment yet) >
There's no need to apologize; we don't expect every developer to be able to build on every platform. If you are able to set up a Windows build environment that would be very helpful, of course, but if not, a Windows developer can do that. If you just need a quick tests run, you can also trigger buildbot builds of the swig-py3 branch on Windows by joining #svn-dev on IRC and issueing an appropriate command to buildbot's IRC bot. > The only thing I know about it, my patch committed on r1849784 might break > Windows build because of "PY3" macro for swig which added only Unix/Linux > build. However, it might not be a compile error, but might produce improper > codes under py3 environment, and this might be dissolved on r1853592, > for "PY3" macro in swig typemaps no longer used. > OK. > > I think there are still some other points need to look over. > > * Do scrpts under tools/ work on py3? Good call: the branch should not cause regressions in tools/ scripts that use the SWIG bindings. That said, I would assume that Python scripts that don't use the swig bindings are orthogonal to the branch; they _should_ be ported to Python 3, but that work can happen on trunk, before or after the merge. > * If we want to install py2 bindings and py3 bindings at the same time, > we must rename libsvn_swig_py library for py3. Good question, but I don't know the answer. Thanks, Daniel
