Mark Phippard wrote on Fri, 04 Jan 2019 16:23 -0500: > On Fri, Jan 4, 2019 at 3:27 PM Daniel Shahaf <d...@daniel.shahaf.name> wrote: > > Mark Phippard wrote on Fri, Jan 04, 2019 at 14:12:07 -0500: > > +1, LGTM. Please change the double quotes to single quotes before you > > commit. (The way you have it is not an sh syntax error, but it will > > output an HTML syntax error.) > > > > In terms of the HTML it has to be double-quotes, single-quotes are not > valid here.
Your sh code would print no quotes at all, neither single nor double. («echo "foo"bar"baz"» prints «foobarbaz».) If the tag must use double quotes then we should use . echo '<pre style="border: none">' Cheers, Daniel