On 2018/10/30 09:22:56, Branko Čibej <br...@apache.org> wrote:
>
> [[[
> .../repos/1.11.x$ ../trunk/tools/dist/nominate.pl r1845204 "Prevents a crash
> in mod_http2."
> Index: STATUS
> ===================================================================
> --- STATUS (revision 1845205)
> +++ STATUS (working copy)
> @@ -48,6 +48,14 @@ Candidate changes:
> Votes:
> +1: brane
>
> + * r1845204
> + Fix issue SVN-4782: Do not use (const char*)1 in httpd modules as value
> for
> + r->notes.
> + Justification:
> + Prevents a crash in mod_http2.
> + Votes:
> + +1: brane
> +
> Veto-blocked changes:
> =====================
>
> Commit this nomination?
> ]]]
>
> (typing y<enter> will commit, anything else will revert the change to
> STATUS).
>
> Our currently maintained branches are 1.9.x, 1.10.x and 1.11.x; fixing a
Done for all 3 branches via the perl script as shown above
BTW, I had to apply the following patch to nominate.pl to get it running with
perl 5.16.3 on CentOS 7:
Index: tools/dist/backport.pl
===================================================================
--- tools/dist/backport.pl (revision 1845203)
+++ tools/dist/backport.pl (working copy)
@@ -791,8 +791,8 @@
# Add to state votes that aren't '+0' or 'edit'
$state->{$_->{digest}}++ for grep
- ($_->{approval} or $_->{vote} =~
/^(-1|-0|[+]1)$/),
- @votesarray;
+ (($_->{approval} or $_->{vote} =~
/^(-1|-0|[+]1)$/),
+ @votesarray);
}
}
I am happy to commit this if this is fine with later versions of perl which I
have not at hand for testing.
Regards
Rüdiger
