Evgeny Kotkov <evgeny.kot...@visualsvn.com> writes: > Daniel Shahaf <d...@daniel.shahaf.name> writes: > >>> + * >>> + * Any temporary allocations may be performed in @a scratch_pool. >> >> Need to add an @since tag here. > > [...] > >>> + */ >>> + svn_error_t *(*apply_textdelta_stream)( >> >> Could you update the docstring of svn_delta_editor_t itself to mention this >> new callback? All other callbacks are discussed there. > > [...] > >>> + const svn_delta_editor_t *editor, >> >> This parameter is undocumented. > > Thank you for the review. I agree with these three points, and will try > to make the suggested tweaks to the documentation.
Committed in r1816063. Daniel Shahaf <d...@daniel.shahaf.name> writes: > +1, but note that the "shouldn't" language in current HEAD, which this > patch [once rebased to HEAD] will remove, was copied from some other > docstring. I made no note of which one specifically, because I think > that "shouldn't" language is our standard formula for docstrings of > non-opaque struct types. Committed in r1816066. Regards, Evgeny Kotkov
