Evgeny Kotkov wrote:
Julian Foad <julianf...@apache.org> writes:
Don't replace it with 'relpath &&' instead, however. If relpath is null then
I think the next line (svn_hash_gets(..., relpath)) would immediately crash
anyway, so allowing it here is useless and therefore confusing. Remove that
condition entirely. That's my suggestion.
The condition is inverted in the sense that it checks for a null relpath
and returns if so — in other words, the svn_hash_gets() won't get called
if the relpath is null.
Oh... oops! I was confused. Right you are.
However, as it turns out, this condition can indeed be simplified by not
checking for null, as the only calling site where the relpath might be
null, setup_proppatch_headers(), already checks for it. (Among the other
two calling sites, the relpath cannot be null as it would have segfaulted
earlier).
I committed this simplification in r1816061, thanks!
Thanks.
- Julian
