Evgeny Kotkov wrote on Wed, 26 Jul 2017 15:48 +0300:
> And building using an embedded copy of the source isn't something new,
> as we already do that for utf8proc and with sqlite-amalgamation.
utf8proc is indeed a precedent, but sqlite is not.
- We support linking against an external sqlite lib too, not just
against sqlite-amalgamation. (On Unix, at least, which is what stsp
and Philip discuss)
- sqlite-amalgamation is not _embedded_ in the source; it is retrieved
by the user, so they can use an sqlite that was released after the
subversion tarball they're building.
> Furthermore, we only require the core part of the LZ4 library — that is, two
> relatively small files (lz4.c and lz4.h), which I think were specifically
> designed this way to simplify the process of using LZ4 in various
> applications.
This may be related to something I've been meaning to bring up: adding
lz4 has added five new warnings to the build (see attachment). I meant
to bring them up and ask if they could please be addressed, but I wonder
if those warnings are related to your "designed to be importable" point.
Cheers,
Daniel
% make -s svnadmin
subversion/libsvn_subr/lz4/lz4.c:707:5: warning: no previous prototype for
function 'LZ4_compress_fast_force'
[-Wmissing-prototypes]
int LZ4_compress_fast_force(const char* source, char* dest, int inputSiz...
^
subversion/libsvn_subr/lz4/lz4.c:1037:5: warning: no previous prototype for
function 'LZ4_compress_forceExtDict'
[-Wmissing-prototypes]
int LZ4_compress_forceExtDict (LZ4_stream_t* LZ4_dict, const char* sourc...
^
subversion/libsvn_subr/lz4/lz4.c:1395:5: warning: no previous prototype for
function 'LZ4_decompress_safe_forceExtDict'
[-Wmissing-prototypes]
int LZ4_decompress_safe_forceExtDict(const char* source, char* dest, in...
^
subversion/libsvn_subr/lz4/lz4.c:1418:5: warning: no previous prototype for
function 'LZ4_uncompress' [-Wmissing-prototypes]
int LZ4_uncompress (const char* source, char* dest, int outputSize) { re...
^
subversion/libsvn_subr/lz4/lz4.c:1419:5: warning: no previous prototype for
function 'LZ4_uncompress_unknownOutputSize'
[-Wmissing-prototypes]
int LZ4_uncompress_unknownOutputSize (const char* source, char* dest, in...
^
5 warnings generated.
