On Wed, May 03, 2017 at 10:05:01PM +0200, Lukas Jirkovsky wrote: > New version. Instead of reimplementing the gpg-agent logic, "gpgconf > --list-dir agent-socket" is used. If the gpgconf fails, the code falls > back to the original solution to stay compatible with old Gnupg > versions.
Thanks Lukas, this patch looks good to me. I have just one minor stylistic nit: The local scratch_pool created in your new function is not necessary. This code could be simplified further by just using 'pool' throughout. In any case, I would not object to having your patch committed as it is. The scratch_pool is just a small detail. It would be good if you could send patches as a unidiff in the future. 'svn diff' produces such output by default, and 'diff -u' works, too. Regards, Stefan
