On 13.05.2016 19:51, Evgeny Kotkov wrote:
Stefan Fuhrmann<stef...@apache.org> writes:
The new condition looks fairly suspicious.
Sure, but no worse than before.
I think it's actually worse than before, as now it looks like this function
was updated for Python 3, whereas in fact it gets all the special cases
like "value[0] == '-'" wrong. And we will probably trip over this in the
future.
Well, I only wanted to say that py3 wasn't supported
before either.
How about doing it as in the attached patch?
That seems to work. Committed in r1743956.
Thanks for the patch!
-- Stefan^2.
