On 31.01.2016 17:30, Bert Huijben wrote:
-----Original Message-----
From: stef...@apache.org [mailto:stef...@apache.org]
Sent: zondag 31 januari 2016 17:18
To: comm...@subversion.apache.org
Subject: svn commit: r1727838 - in /subversion/trunk/subversion:
include/private/svn_fs_util.h libsvn_fs/fs-loader.c libsvn_fs_util/fs-util.c
tests/cmdline/svnadmin_tests.py
Author: stefan2
Date: Sun Jan 31 16:18:26 2016
New Revision: 1727838
URL: http://svn.apache.org/viewvc?rev=1727838&view=rev
Log:
Add the ability to emulate the old svn_fs_paths_changed2 through
svn_fs_paths_changed3. So, we've got a two-way emulation now and
we enable both for now such that all callers of the old API will
be redirected: old API -> new API -> old API vtable entry.
On the buildbot:
svn_fs_util-1.lib(fs-util.obj) : error LNK2019: unresolved external symbol
_svn_fs_txn_root_base_revision referenced in function _svn_fs__get_deleted_node
[D:\ra\svn-ra\build\build\win32\vcnet-vcproj\libsvn_fs_util_dll.vcxproj]
svn_fs_util-1.lib(fs-util.obj) : error LNK2019: unresolved external symbol
_svn_fs_revision_root referenced in function _svn_fs__get_deleted_node
[D:\ra\svn-ra\build\build\win32\vcnet-vcproj\libsvn_fs_util_dll.vcxproj]
svn_fs_util-1.lib(fs-util.obj) : error LNK2019: unresolved external symbol
_svn_fs_root_fs referenced in function _svn_fs__get_deleted_node
[D:\ra\svn-ra\build\build\win32\vcnet-vcproj\libsvn_fs_util_dll.vcxproj]
svn_fs_util-1.lib(fs-util.obj) : error LNK2019: unresolved external symbol
_svn_fs_copied_from referenced in function _svn_fs__get_deleted_node
[D:\ra\svn-ra\build\build\win32\vcnet-vcproj\libsvn_fs_util_dll.vcxproj]
svn_fs_util-1.lib(fs-util.obj) : error LNK2019: unresolved external symbol
_svn_fs_revision_root_revision referenced in function _svn_fs__get_deleted_node
[D:\ra\svn-ra\build\build\win32\vcnet-vcproj\libsvn_fs_util_dll.vcxproj]
svn_fs_util-1.lib(fs-util.obj) : error LNK2019: unresolved external symbol
_svn_fs_closest_copy referenced in function _svn_fs__get_deleted_node
[D:\ra\svn-ra\build\build\win32\vcnet-vcproj\libsvn_fs_util_dll.vcxproj]
Looks like that we reintroduced a circular dependency between libsvn_fs and
libsvn_fs_util (again).
(Welcome in the club... I introduced the same problem on the git branch)
*Sigh*. Sorry for that!
Feel free to move the code around to libfs
(and the declaration to fs_private.h) or so.
I won't be online today until later tonight.
-- Stefan^2.
