> -----Original Message----- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: maandag 23 november 2015 15:31 > To: dev@subversion.apache.org; Bert Huijben <b...@qqmail.nl> > Subject: Re: svn commit: r1715832 - /subversion/trunk/win-tests.py > > On 23 November 2015 at 17:29, <rhuij...@apache.org> wrote: > > Author: rhuijben > > Date: Mon Nov 23 14:29:59 2015 > > New Revision: 1715832 > > > > URL: http://svn.apache.org/viewvc?rev=1715832&view=rev > > Log: > > * win-tests.py > > (Svnserve.start): Pass the SVN_DBG_STACKTRACES_TO_STDERR > environment > > variable to svnserve.exe to get more information on crashes on testruns. > > > > Modified: > > subversion/trunk/win-tests.py > > > > Modified: subversion/trunk/win-tests.py > > URL: http://svn.apache.org/viewvc/subversion/trunk/win- > tests.py?rev=1715832&r1=1715831&r2=1715832&view=diff > > > ========================================================== > ==================== > > --- subversion/trunk/win-tests.py (original) > > +++ subversion/trunk/win-tests.py Mon Nov 23 14:29:59 2015 > > @@ -447,7 +447,9 @@ class Svnserve: > [...] > > > if use_ssl and use_http2: > > - fp.write('Protocols h2 http/1.1\n') > > + fp.write('Protocols h2\n') > > elif use_http2: > > - fp.write('Protocols h2c http/1.1\n') > > + fp.write('Protocols h2c\n') > > fp.write('H2Direct on\n') > ^^^ Looks like unintended change.
Yes... Although it isn't as bad as it looks. Before this patch the server side supported http/1.1 and h2 when you enabled http/2. Now it only supports http2 in this mode. I'll revert this bit. I added this patch locally as I couldn't believe how many tests were passing. Thanks for your review! Bert