On 28 May 2015 at 23:55, Bert Huijben <b...@qqmail.nl> wrote: > In this case the log message documented that it fixed ‘a problem on > Windows’, which would suggest at least some Windows testing > [[ > Correctly fsync() after renames in FSFS on Win32. We must flush the disk > buffers after the rename, otherwise the metadata may not be persistent. > Moreover, if the rename is degraded to a copy by Win32, we won't even have > the complete file contents on disk without a buffer flush. > ]] > > The original code worked just fine in 1.7 and 1.8 before this patch, so some > explanation on what problem is fixed, how to reproduce the problem and how > this impacts performance would be welcome. > +1.
[...] >> >> Did >> >> you able to reproduce data corruption on VM? >> > >> > >> > No. But I did not even try. >> > >> I really hope that you have tested your patch on Windows before commit. > > I really hope you're joking. We've never required or expected testing on all > platforms, from anyone. > Do you say that testing platform specific fix on the platform affected is not good practice -- Ivan Zhakov CTO | VisualSVN | http://www.visualsvn.com
