On Thu, Mar 19, 2015 at 12:42 PM, Julian Foad <julianf...@gmail.com> wrote: > Johan Corveleyn wrote: >> Another step further, but now I get this (don't really understand why): >> >> [[[ >> libsvn_delta.def : error LNK2001: unresolved external symbol >> svn_editor3__insert_shims > > That function is declared in svn_editor3e.h and never defined nor referenced. > > Rather than debug why it's reported as an unresolved symbol, I have > removed the declaration in r1667708. > >> libsvn_delta.def : error LNK2001: unresolved external symbol >> svn_editor3p_res > > svn_editor3p_res() is only ever defined and referenced inside #ifdef > SVN_EDITOR3_WITH_RESURRECTION ... and that should not be defined. Is > the problem caused by the MSVC project generator detecting this > declaration in the header file, even though it's ifdef'd out, and then > telling MSVC to 'export' it even though it's not defined? If so, for > now, can you just delete its declaration locally? > > I guess that would also explain svn_editor3__insert_shims().
Yes, that's it. When I delete the declaration of svn_editor3p_res() from private/svn_editor3p.h locally, I get past that error. But now I'm running into a new one: [[[ svn_ra-1.lib(ra_loader.obj) : error LNK2019: unresolved external symbol _svn_delta__get_debug_editor referenced in function _svn_ra_get_commit_editor_ev3 [C:\research\svn\dev\move-tracking-2\build\win32\vcnet-vcproj\libsvn_ra_dll.vcxproj] C:\research\svn\dev\move-tracking-2\Debug\subversion\libsvn_ra\libsvn_ra-1.dll : fatal error LNK1120: 1 unresolved externals [C:\research\svn\dev\move-tracking-2\build\win32\vcnet-vcproj\libsvn_ra_dll.vcxproj] ]]] I suppose the problem is that svn_delta_get_debug_editor is being referenced from libsvn_ra/ra_loader.c, but it is only defined in debug_editor.h which is private to libsvn_delta. It seems it was introduced on the move-tracking-2 branch in r1634591. -- Johan
