On Fri, Feb 13, 2015 at 11:01:52PM +0100, Stefan Kueng wrote: > Hi, > > While trying out the new 'pin externals' feature, I found a problem: > > if the external definition has spaces in them for the local path, something > like this: > > ^/branches/test1 'ext with spaces' > > then that will get changed to > ^/branches/test1@1234 ext with spaces > > which basically breaks the externals value. > > > Also, I get a segfault in copy.c, line 1331: > info->src_path = svn_relpath_join(parent_info->src_path, > dst_relpath, > result_pool); > because in my first tests, the 'parent_info->src_path' is NULL. > Haven't found out why yet, just wanted to mention it. > > > And one more: > The 'externals_to_pin' hash that's passed to svn_client_copy7() is supposed > to contain all the externals that should be pinned. > But it appears that it must contain *all* externals as keys, even those that > should not be pinned. In that case, only the array (hash value) has to be > empty. Maybe the doc string should indicate that? Or maybe the feature is > wrong and a key path that's not in the hash should be treated as > not-to-be-pinned? > > Stefan > > -- > ___ > oo // \\ "De Chelonian Mobile" > (_,\/ \_/ \ TortoiseSVN > \ \_/_\_/> The coolest interface to (Sub)version control > /_/ \_\ http://tortoisesvn.net
Hi Stefan, Can you please file issues for these problems, with a 1.9.0 milestone? Thanks!
