Hello,

> I saw build errors in the bindings with SWIG 3.0.4:
> ./subversion/bindings/swig/core.i:792: Error: Unknown SWIG preprocessor
> directive: The (if this is a block of target language code, delimit it
> with %{ and %})

And here is the missing part for proxy.swg for review...

[[[
Follow-up to 1655262,1658347: Fix for python bindings build with Swig 3.0.x

* subversion/bindings/swig/include/proxy.swg:
  Escape comments

Patch by: Dominique Leuenberger <dims...@opensuse.org>
Found by: me
]]]

Andreas
Index: subversion/bindings/swig/include/proxy.swg
===================================================================
--- subversion/bindings/swig/include/proxy.swg	(revision 1658942)
+++ subversion/bindings/swig/include/proxy.swg	(working copy)
@@ -83,13 +83,13 @@
 
     value = _swig_getattr(self, self.__class__, name)
 
-    # If we got back a different object than we have, we need to copy all our
-    # metadata into it, so that it looks identical
+%{    # If we got back a different object than we have, we need to copy all our
+    # metadata into it, so that it looks identical%}
     members = self.__dict__.get("_members")
     if members is not None:
       _copy_metadata_deep(value, members.get(name))
         
-    # Verify that the new object is good
+%{    # Verify that the new object is good}%
     _assert_valid_deep(value)
 
     return value
@@ -98,9 +98,9 @@
     """Set an attribute on this object"""
     self.assert_valid()
 
-    # Save a copy of the object, so that the garbage
+%{    # Save a copy of the object, so that the garbage
     # collector won't kill the object while it's in
-    # SWIG-land
+    # SWIG-land%}
     self.__dict__.setdefault("_members",{})[name] = value
 
     return _swig_setattr(self, self.__class__, name, value)

Reply via email to