> -----Original Message----- > From: Julian Foad [mailto:julianf...@btopenworld.com] > Sent: dinsdag 13 januari 2015 15:22 > To: Branko Čibej > Cc: dev@subversion.apache.org > Subject: Re: Testing equality between svnrdump and svnadmin dump > > The next version of my testing patch is attached. It pipes each dumpfile > through > svndumpfilter and checks that a no-op filtering does not change anything.
I haven't reviewed all of this, but I'm wondering why in your patch [[ def parse_path(self): - path = self.parse_line('Node-path: (.+)$', required=False) - if not path and self.lines[self.current] == 'Node-path: \n': - self.current += 1 - path = '' + path = self.parse_line('Node-path: (.*)$', required=False) ]] This replaces '.+' with '.*' I was wondering why this was necessary? (To catch more error? Or does this skip some errors?) Nice catches in the other mails on this subject! Thanks, Bert