On 05.01.2015 18:15, stef...@apache.org wrote: > Author: stefan2 > Date: Mon Jan 5 17:15:27 2015 > New Revision: 1649592 > > URL: http://svn.apache.org/r1649592 > Log: > Follow-up to r1645907: Fix pack test failures seen on macos buildbot. > > * subversion/libsvn_fs_x/fs_x.c > (write_revision_zero): Fix off-by-4 in noderev size. > > Modified: > subversion/trunk/subversion/libsvn_fs_x/fs_x.c > > Modified: subversion/trunk/subversion/libsvn_fs_x/fs_x.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_x/fs_x.c?rev=1649592&r1=1649591&r2=1649592&view=diff > ============================================================================== > --- subversion/trunk/subversion/libsvn_fs_x/fs_x.c (original) > +++ subversion/trunk/subversion/libsvn_fs_x/fs_x.c Mon Jan 5 17:15:27 2015 > @@ -863,7 +863,7 @@ write_revision_zero(svn_fs_t *fs, > "2d2977d1c96f487abe4a1e202dd03b4e\n" > "cpath: /\n" > "\n\n", > - 0x8b, subpool)); > + 0x87, subpool));
Yah. This is why such magic numbers should never appear in the code in the first place. We had a heated discussion this, or some similar code in fsfs7, a while ago ... Is it really that hard to write a rev file constructor function that calculates the magic numbers, including checksum, based on the revision contents? I'd feel a lot safer that way. -- Brane
