On 10 September 2014 20:12, Evgeny Kotkov <evgeny.kot...@visualsvn.com> wrote: > Ivan Zhakov <i...@visualsvn.com> writes: > >>> +@Skip(svntest.main.is_fs_type_fsx) >>> >> I think this test should be skipped for all FS types except FSFS. I.e. >> @SkipUnless(svntest.main.is_fs_type_fsfs) >> >> Did I miss something? > > This was intentional. > > Prior to this change, we actually had no tests covering the 'svnadmin upgrade' > behavior, and I took this opportunity to cover all possible --fs-types with > the > new test. We cannot really do this for FSX, because there are no "compatible > versions", but can do it for BDB and FSFS. Although BDB is deprecated, the > upgrade code indeed does some amount of work, so I thought there is nothing > wrong with also testing it. > > What I could have done, however, is state this information in the log message > (for the future readers' sake). I tweaked it accordingly. > Ok, that's makes sense. Thanks for explanation.
-- Ivan Zhakov
