On 15.08.2014 17:14, kot...@apache.org wrote: > Author: kotkov > Date: Fri Aug 15 16:14:47 2014 > New Revision: 1618219 > > URL: http://svn.apache.org/r1618219 > Log: > Correctly handle a situation of an unresolved SQLite dependency in > our gen_win_dependencies.py script, instead of printing a stacktrace > (TypeError: not all arguments converted during string formatting). > > * build/generator/gen_win_dependencies.py > ( _find_sqlite): The error message does not have any '%s' placeholders, > so there is no need to pass the self.sqlite_path format argument. > > Modified: > subversion/trunk/build/generator/gen_win_dependencies.py > > Modified: subversion/trunk/build/generator/gen_win_dependencies.py > URL: > http://svn.apache.org/viewvc/subversion/trunk/build/generator/gen_win_dependencies.py?rev=1618219&r1=1618218&r2=1618219&view=diff > ============================================================================== > --- subversion/trunk/build/generator/gen_win_dependencies.py (original) > +++ subversion/trunk/build/generator/gen_win_dependencies.py Fri Aug 15 > 16:14:47 2014 > @@ -1381,7 +1381,7 @@ class GenDependenciesBase(gen_base.Gener > lib_name = None > defines.append('SVN_SQLITE_INLINE') > else: > - sys.stderr.write("ERROR: SQLite not found\n" % self.sqlite_path) > + sys.stderr.write("ERROR: SQLite not found\n") > sys.stderr.write("Use '--with-sqlite' option to configure sqlite > location.\n"); > sys.exit(1)
May I suggest that you add the missing %s placeholder instead? I expect the whole point of trying to print the path is to make it easier for the developer to debug her configuration. -- Brnae -- Branko Čibej | Director of Subversion WANdisco | Realising the impossibilities of Big Data e. br...@wandisco.com
