On 8/12/14 12:56 PM, Ivan Zhakov wrote: > My concerns are the following: > 1. Avoid unrelated branch changes > 2. Have some function for converting checksum to canonical form: > a) one option is just leave svn_checksum_to_cstring_display() and > add svn_checksum_to_cstring_display_ex() > b) another option is deprecate svn_checksum_to_cstring_display(), > replacing existing callers with > new svn_checksum_to_cstring_canonical(), but I think it's > better do this on trunk to make review easier.
Per our discussion I'll just remove the svn_checksum_* changes on the branch. After we get the X.509 stuff merged to trunk I'll commit something that changes the checksum output formatting and that accommodates most of your comments. I am still inclined to use flags so that the function can be used in multiple differing cases.
