> -----Original Message----- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: zondag 20 april 2014 17:33 > To: dev@subversion.apache.org > Subject: [Review request] RE: svn commit: r1588772 - in > /subversion/trunk/subversion: mod_dav_svn/repos.c > tests/cmdline/commit_tests.py > > > > > -----Original Message----- > > From: rhuij...@apache.org [mailto:rhuij...@apache.org] > > Sent: zondag 20 april 2014 16:47 > > To: comm...@subversion.apache.org > > Subject: svn commit: r1588772 - in /subversion/trunk/subversion: > > mod_dav_svn/repos.c tests/cmdline/commit_tests.py > > > > Author: rhuijben > > Date: Sun Apr 20 14:46:42 2014 > > New Revision: 1588772 > > > > URL: http://svn.apache.org/r1588772 > > Log: > > Implement an initial fix for issue #4480. As noted in the code this patch > > might make this code report out of date in a few cases where we should > > allow > > a commit, but this is much safer than not reporting out of date where we > > should. > > > > As far as I can tell this check matches how we do things in the repos/fs > > commit api, so I hope somebody with more knowledge of these apis can > > confirm that this is the right fix to close issue #4480. > > Hi all, > > This issue has been bothering me for weeks, because I couldn't think of a > proper way to fix this. > > I think this patch (improved by r1588778) resolves the issue, but I would > welcome reviews. > > > If possible I would like to see this issue fixed in the next 1.8 and 1.7 > releases > as this issue allows breaking merge tracking by overwriting node properties > without a proper out of date check.
Pinging this thread, on a workday... Anybody? > Bert
