On 23 April 2014 15:51, Stefan Fuhrmann <stefan.fuhrm...@wandisco.com> wrote: > > On Wed, Apr 23, 2014 at 1:18 PM, Ivan Zhakov <i...@visualsvn.com> wrote: >> >> On 23 April 2014 14:50, Bert Huijben <b...@qqmail.nl> wrote: >> > On Windows the default stacksize is 1 MB, and as we are in many cases >> > ‘just >> > a library’ we should try to be a bit on the safe side, especially when >> > we >> > call into other code -or are likely to be called from other code- that >> > might >> > have their own buffers. >> > >> > >> > Until recently these buffers weren’t that big… Now that they are on >> > trunk we >> > should probably move them to a short lived scratch pool… or reduce them >> > back >> > to their original size. >> > >> I've vetoed increasing read buffer size recently and going to revert >> r1586922: make SVN__STREAM_CHUNK_SIZE 16k again and implement >> optimization and FSFS layer. > > > Give me at least a chance to work through the backlog of > issues to you raised before reverting stuff. > No problem. Anyway I was not going to revert your change completely: I wanted reimplemented your dynamic compare buffer on FSFS layer instead of generic stream.
-- Ivan Zhakov CTO | VisualSVN | http://www.visualsvn.com
