On 21 April 2014 12:21, Ivan Zhakov <i...@visualsvn.com> wrote:
> On 20 April 2014 22:35, <stef...@apache.org> wrote:
>> Author: stefan2
>> Date: Sun Apr 20 18:35:43 2014
>> New Revision: 1588815
>>
>> URL: http://svn.apache.org/r1588815
>> Log:
>> Enable FSFS to take out more than file lock at once through a single call.
>> Use that functionality to take out the new pack lock for upgrade, hotcopy
>> and recovery. Also, disallow new TXNs during upgrade and recovery.
>>
>> The core is the introduction of a new data type describing a lock to take
>> out, which can be nested / chained. Switch all existing lock function to
>> using that infrastructure.
>>
> [...]
>
Also this commit seems to break two svnadmin tests at least on Windows:
[[[
At least one test FAILED, checking C:\Ivan\SVN\test\tests.log
FAIL: svnadmin_tests.py 8: 'svnadmin hotcopy PATH .'
FAIL: svnadmin_tests.py 27: 'svnadmin hotcopy --incremental PATH .'
]]]
[[[
W: CWD: C:\Ivan\SVN\test\subversion\tests\cmdline
W: EXCEPTION: Failure: svn-test-work\repositories\svnadmin_tests-8\db\pack-lock does not exist in hotcopy source
Traceback (most recent call last):
File "C:\Ivan\SVN\trunk\subversion\tests\cmdline\svntest\main.py", line 1613, in run
rc = self.pred.run(sandbox)
File "C:\Ivan\SVN\trunk\subversion\tests\cmdline\svntest\testcase.py", line 176, in run
return self.func(sandbox)
File "C:\Ivan\SVN\trunk\subversion\tests\cmdline\svnadmin_tests.py", line 555, in hotcopy_dot
check_hotcopy_fsfs(sbox.repo_dir, backup_dir)
File "C:\Ivan\SVN\trunk\subversion\tests\cmdline\svnadmin_tests.py", line 159, in check_hotcopy_fsfs
check_hotcopy_fsfs_fsx(src, dst)
File "C:\Ivan\SVN\trunk\subversion\tests\cmdline\svnadmin_tests.py", line 78, in check_hotcopy_fsfs_fsx
"source" % src_dirent)
Failure: svn-test-work\repositories\svnadmin_tests-8\db\pack-lock does not exist in hotcopy source
FAIL: svnadmin_tests.py 8: 'svnadmin hotcopy PATH .'
]]]
[[[
W: CWD: C:\Ivan\SVN\test\subversion\tests\cmdline
W: EXCEPTION: Failure: svn-test-work\repositories\svnadmin_tests-27\db\pack-lock does not exist in hotcopy source
Traceback (most recent call last):
File "C:\Ivan\SVN\trunk\subversion\tests\cmdline\svntest\main.py", line 1613, in run
rc = self.pred.run(sandbox)
File "C:\Ivan\SVN\trunk\subversion\tests\cmdline\svntest\testcase.py", line 254, in run
return self._delegate.run(sandbox)
File "C:\Ivan\SVN\trunk\subversion\tests\cmdline\svntest\testcase.py", line 176, in run
return self.func(sandbox)
File "C:\Ivan\SVN\trunk\subversion\tests\cmdline\svnadmin_tests.py", line 1752, in hotcopy_incremental
check_hotcopy_fsfs(sbox.repo_dir, backup_dir)
File "C:\Ivan\SVN\trunk\subversion\tests\cmdline\svnadmin_tests.py", line 159, in check_hotcopy_fsfs
check_hotcopy_fsfs_fsx(src, dst)
File "C:\Ivan\SVN\trunk\subversion\tests\cmdline\svnadmin_tests.py", line 78, in check_hotcopy_fsfs_fsx
"source" % src_dirent)
Failure: svn-test-work\repositories\svnadmin_tests-27\db\pack-lock does not exist in hotcopy source
FAIL: svnadmin_tests.py 27: 'svnadmin hotcopy --incremental PATH .'
]]]
