On 20 April 2014 22:02, <stef...@apache.org> wrote: > Author: stefan2 > Date: Sun Apr 20 18:02:40 2014 > New Revision: 1588812 > > URL: http://svn.apache.org/r1588812 > Log: > * subversion/libsvn_fs_fs/transaction.c > (fnv1a_checksum_on_file_range): Use our standard stream / file data block > size instead of some local constant. > > Found by: ivan > > Modified: > subversion/trunk/subversion/libsvn_fs_fs/transaction.c > > Modified: subversion/trunk/subversion/libsvn_fs_fs/transaction.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/transaction.c?rev=1588812&r1=1588811&r2=1588812&view=diff > ============================================================================== > --- subversion/trunk/subversion/libsvn_fs_fs/transaction.c (original) > +++ subversion/trunk/subversion/libsvn_fs_fs/transaction.c Sun Apr 20 > 18:02:40 2014 > @@ -3567,7 +3567,7 @@ fnv1a_checksum_on_file_range(apr_uint32_ > apr_off_t size, > apr_pool_t *pool) > { > - char buffer[4096]; > + char buffer[SVN__STREAM_CHUNK_SIZE]; > Allocating 64k on stack is not good thing imho. Currently we always allocate such buffers from pool and this case looks like another premature optimization.
--- Ivan Zhakov CTO | VisualSVN | http://www.visualsvn.com
