On 03.04.2014 20:15, Julian Foad wrote:
>>> URL: http://svn.apache.org/viewvc?rev=1344347&view=rev
>>> Log:
>>> Remove about 15% of the cpu overhead of svnserve and httpd while running
>>> the test suite by introducing a very simple parser buffer in the config file
>>> parser code.
> [...]
>>>   * subversion/libsvn_subr/config_file.c
>>>    (parse_context_t): Add buffer and position variables. Use EOF as no 
>>> ungetc var.
> [...]
>>>   Modified: subversion/trunk/subversion/libsvn_subr/config_file.c
>>> ==============================================================================
>>>   +
>>>   +  /* Parser buffer for getc() to avoid call overhead into several 
>>> libraries
>>>   +     for every character */
>>>   +  char parser_buffer[SVN_STREAM_CHUNK_SIZE];
> [...]
>
> This commit implements buffering of a generic stream, directly in the config 
> file parser. Would it not be better to implement buffering of a generic 
> stream as a generic module?

We already have svn_stream_buffered.

-- Brane


-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. br...@wandisco.com

Reply via email to