"Bert Huijben" <b...@qqmail.nl> writes: >> + expiration_date, steal_lock, pool, pool); >> + >> + if (apr_hash_count(results)) > > Is this function explicitly documented to always set the results value > on all error paths? > > I don't see that in the documentation for svn_fs_lock2?
It is now. > And it is certainly not our standard pattern for public > functions... By default the output arguments are undefined on error. It's necessary to allow the caller to handle all the errors. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*