> URL: http://svn.apache.org/r1577170

> Log:
> Following up on r1577164, remove the special '*' argument handling from all
> Subversion .exe's except the few that really need this.
> 
> After this patch
> $ svnmucc.exe propset svn:special "*" URL -m "set svn:special"
> 
> will work on Windows, while this would try to evaluate '*' before.

I understand it's nice to not expand the '*' in this particular case, and maybe 
in all svnmucc commands. However, I am concerned about the inconsistency this 
introduces between the various svn command-line programs. It looks like

  svnmucc propset svn:special "*" URL

will set the prop val to '*', but

  svn propset svn:special "*" WC-path

will expand the '*'.

Is this really what we want to give the Windows users?

- Julian

[I mentioned it to Bert on IRC: 
<http://colabti.org/irclogger/irclogger_log/svn-dev?date=2014-03-13#l198>.]


> * build.conf
>   (svn,
>    svnadmin): Add setargv.obj to msvc-libs.
> 
> * build/generator/gen_win.py
>   (get_win_libs): Remove magic dependency of all .exe's.

> Modified: subversion/trunk/build.conf
> ==============================================================================
> @@ -146,6 +146,7 @@
> +msvc-libs = setargv.obj
> 
> @@ -155,6 +156,7 @@
> +msvc-libs = setargv.obj
> 
> Modified: subversion/trunk/build/generator/gen_win.py
> ==============================================================================
> @@ -867,9 +867,6 @@ class WinGeneratorBase(gen_win_dependenc
> 
>      nondeplibs = target.msvc_libs[:]
> 
> -    if isinstance(target, gen_base.TargetExe):
> -      nondeplibs.append('setargv.obj')
> -

Reply via email to