On Mon, Mar 17, 2014 at 9:47 AM, Bert Huijben <b...@qqmail.nl> wrote:
> > > > -----Original Message----- > > From: stef...@apache.org [mailto:stef...@apache.org] > > Sent: maandag 17 maart 2014 00:10 > > To: comm...@subversion.apache.org > > Subject: svn commit: r1578176 - in > > /subversion/trunk/subversion/libsvn_fs_fs: fs.c fs.h fs_fs.c fs_fs.h > pack.c > > > > Author: stefan2 > > Date: Sun Mar 16 23:09:45 2014 > > New Revision: 1578176 > > > > URL: http://svn.apache.org/r1578176 > > Log: > > Model the FSFS pack lock similarly to our other file based locks in FSFS. > > This gives us proper mutex functionality should multiple threads try to > > pack the same repo at the same time. > > > > * subversion/libsvn_fs_fs/fs.h > > (fs_fs_shared_data_t): Add a thread mutex alongside the file lock. > > > > * subversion/libsvn_fs_fs/fs.c > > (fs_serialized_init): Initialize the new mutex. > > > > * subversion/libsvn_fs_fs/fs_fs.h > > (svn_fs_fs__get_lock_on_filesystem): Privatize again. > > (svn_fs_fs__with_pack_lock): New lock handling function similar > > to what we do for the other locks. > > > > * subversion/libsvn_fs_fs/fs_fs.c > > (path_pack_lock): New utility function. > > (svn_fs_fs__get_lock_on_filesystem): Rename back to ... > > (get_lock_on_filesystem): ... this again. > > (with_some_lock_file): Update caller. > > (svn_fs_fs__with_pack_lock): Implement the new lock function. > > > > * subversion/libsvn_fs_fs/pack.c > > (svn_fs_fs__pack): Use the new pack lock handling function. > > > It looks like this patch also removed a subpool around the packing in > pack.c. > > Was that an intended behavior change? > Yes, it is. The subpool is already provided by the with_some_lock_file() function in fs_fs.c. -- Stefan^2.
