Ben Reser <b...@reser.org> writes: > On 2/3/14, 4:31 PM, Daniel Shahaf wrote: >> Do you need to call __close if there is an error after __start? i.e., >> is there a state in which stdout will be printed to in the error path? > > Yes you do. Just try running svn diff against a non-working copy. You'll end > up with a broken terminal that you have to reset to see what you're doing.
We want some pattern that ensures __close is always called even when an error is returned part way through. Either a pool cleanup or some sort of __with_pager(). Otherwise we have to ensure that none of the error pass bypass __close, e.g. PAGER=less svn diff wc file:/// leaves me needing to reset my terminal. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*
