On 12/2/13, 6:46 AM, stef...@apache.org wrote: > Author: stefan2 > Date: Mon Dec 2 14:46:11 2013 > New Revision: 1547035 > > URL: http://svn.apache.org/r1547035 > Log: > * subversion/tests/svn_test_main.c > (main): Allow for testing compatibility with 1.7 and 1.8. > > Modified: > subversion/trunk/subversion/tests/svn_test_main.c > > Modified: subversion/trunk/subversion/tests/svn_test_main.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/svn_test_main.c?rev=1547035&r1=1547034&r2=1547035&view=diff > ============================================================================== > --- subversion/trunk/subversion/tests/svn_test_main.c (original) > +++ subversion/trunk/subversion/tests/svn_test_main.c Mon Dec 2 14:46:11 2013 > @@ -788,7 +788,7 @@ main(int argc, const char *argv[]) > exit(1); > } > if ((opts.server_minor_version < 3) > - || (opts.server_minor_version > 6)) > + || (opts.server_minor_version > 8))
Shouldn't this be opts.server_minor_version >= SVN_VER_MINOR so we don't have to remember to update this everytime? Doesn't help if we change the major, but the code already has that issue.
