On 07.12.2013 11:00, Bert Huijben wrote: > >> -----Original Message----- >> From: stef...@apache.org [mailto:stef...@apache.org] >> Sent: zaterdag 7 december 2013 10:31 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1548823 - in >> /subversion/trunk/subversion/libsvn_fs_x: dag.c id.c id.h temp_serializer.c >> temp_serializer.h >> >> Author: stefan2 >> Date: Sat Dec 7 09:30:42 2013 >> New Revision: 1548823 >> >> URL: http://svn.apache.org/r1548823 >> Log: >> Add a pool member to the internal representation of FSX IDs and >> thus allow the ID vtable functions to perform actual data lookups >> in the future. The pool is the one used to allocate the ID. > With WC-NG we explicitly stopped adding a pool in this kind of structures for > very good reasons. All these pool reference makes it harder and harder to > properly allocate results. This pattern is far too sensitive to pool cleanup > ordering problems > > Using proper result and scratch pool (where the scratch pool is always the > result pool or a descendant of the result pool or at least a pool that is > cleaned up *before* the result pool), makes pool cleanup handling much easier > to understand...
Couldn't agree more. Structs carrying their own pools around (except in very limited cases, such as stringbufs and similar) are dangerous. -- Brane -- Branko Čibej | Director of Subversion WANdisco // Non-Stop Data e. br...@wandisco.com
