Hi,

I've noticed that the 'recover_get_largest_revision' routine currently contains
duplicate svn_pool_clear(ITERPOOL) calls.  This change was introduced in
r1546842 [1] and I've attached a patch to fix this.

Log message:
[[[
Do not call svn_pool_clear(ITERPOOL) twice.  Follow-up to r1546842.

* subversion/libsvn_fs_fs/recovery.c
  (recover_get_largest_revision): Do not call svn_pool_clear(ITERPOOL) twice.

Patch by: Evgeny Kotkov <evgeny.kotkov{_AT_}visualsvn.com>
]]]


[1] http://svn.apache.org/viewvc?view=revision&revision=r1546842


Thanks and regards,
Evgeny Kotkov
Index: subversion/libsvn_fs_fs/recovery.c
===================================================================
--- subversion/libsvn_fs_fs/recovery.c  (revision 1547309)
+++ subversion/libsvn_fs_fs/recovery.c  (working copy)
@@ -56,7 +56,6 @@ recover_get_largest_revision(svn_fs_t *fs, svn_rev
       svn_error_t *err;
       svn_fs_fs__revision_file_t *file;
       svn_pool_clear(iterpool);
-      svn_pool_clear(iterpool);
 
       err = svn_fs_fs__open_pack_or_rev_file(&file, fs, right, iterpool);
       if (err && err->apr_err == SVN_ERR_FS_NO_SUCH_REVISION)
@@ -80,7 +79,6 @@ recover_get_largest_revision(svn_fs_t *fs, svn_rev
       svn_error_t *err;
       svn_fs_fs__revision_file_t *file;
       svn_pool_clear(iterpool);
-      svn_pool_clear(iterpool);
 
       err = svn_fs_fs__open_pack_or_rev_file(&file, fs, probe, iterpool);
       if (err && err->apr_err == SVN_ERR_FS_NO_SUCH_REVISION)

Reply via email to