On 24.10.2013 17:00, phi...@apache.org wrote: > Author: philip > Date: Thu Oct 24 15:00:12 2013 > New Revision: 1535399 > > URL: http://svn.apache.org/r1535399 > Log: > Cast NULL to (char *) in vararg calls to svn_dirent_join_many > and svn_path_join_many.
Why? On which platform do you expect a char* to have a different size and/or representation than a void*? If you can't point to a specific crash caused by passing NULL instead of (char*)NULL, then you've messed up the diffs for no good reason. -- Brane P.S.: I'm well aware that, according to a strict interpretation of the C standard, (void*)0 and (char*)0 are not interchangeable. But we do not support a single platform where the ABI does not treat them identically. Which is why I throw a fit every time I see someone casting (void*) to something else (in C, not C++), or worse, the other way around -- other than to add or remove const. -- Branko Čibej | Director of Subversion WANdisco // Non-Stop Data e. br...@wandisco.com
