Ivan Zhakov wrote on Wed, Aug 07, 2013 at 13:07:27 +0400: > On Wed, Aug 7, 2013 at 1:02 PM, Daniel Shahaf <danie...@elego.de> wrote: > > Please use text/* MIME type. The .c file was so but the .patch wasn't, > > and that gets in the way of reviewing it. More below... > > > > Roderich Schupp wrote on Wed, Aug 07, 2013 at 08:27:43 +0200: > >> This patch reduces the cumulative time for svn_repos_authz_check_access > >> (when called repeteadly in the same connection) for more than 50% > >> (e.g. running the attached test program on a large body of paths). > >> > > > > Can this break anything? > > > > For example, when a client uses a long-lived keep-alive connection and > > the authz file changes during the life of that connection, will your > > change cause the changes to be picked up later than they would before > > your patch? > > > We already cache authz in memory for connection. So this is not issue.
I think you misread my question. I didn't ask "Does the patch cause authz files to be cached", I asked "Does it cause them to be cached for longer than they are already cached".
