On Wed, Jul 10, 2013 at 9:33 PM, Greg Stein <gst...@gmail.com> wrote: > I don't think you want to do it this way. > > * keep the (now-renamed) "detect_chunking" flag separate, and in the > session. it may be "local" to open() right now, but in the future it > may be used as part of an operation's "first request" > > * detect_chunking remains a boolean, and it can be set to FALSE when > the first probe is done (whether that is OPTIONS or a REPORT or...) > > * don't alter the probe or the request logic. it is fine. consider: > - "auto": set detect_chunking, set using_chunked_requests > - "yes": clear detect_chunking, set using_chunked_requests > - "no": clear detect_chunking, clear using_chunked_requests > In other words, you can get away with a simple change to serf.c for > the "auto" work
Deleted the branch and redid it as described above. I do like this implementation better. See r1502401.