Daniel Shahaf wrote on Tue, Jul 09, 2013 at 16:20:56 +0000:
> I accept that some API users may depend on SVN_ERR_RA_SERF_WRAPPED_ERROR. Do
> you think it is a problem to assign that new meaning to it in 1.8.x? I reused
> it for the same reasons you re-used an existing error code in r1498851, if you
> think a new error code is needed on trunk I'm happy to add one.
Looking at your comment:
The reason for the -1 is the re-use of a specific error code
that is automatically unwrapped in some ra_serf code, to
avoid
handling codes like APR_EOF as non fatal)
Weere does ra_serf *unwrap* SVN_ERR_RA_SERF_WRAPPED_ERROR?
% grep 'SVN_ERR.*SERF' subversion/*rf/*.[hc]
subversion/libsvn_ra_serf/options.c:
SVN_ERR_ASSERT(SVN_RA_SERF__HAVE_HTTPV2_SUPPORT(session));
subversion/libsvn_ra_serf/options.c:
SVN_ERR_ASSERT(!SVN_RA_SERF__HAVE_HTTPV2_SUPPORT(session));
subversion/libsvn_ra_serf/serf.c: SVN_ERR_ASSERT(!
SVN_RA_SERF__HAVE_HTTPV2_SUPPORT(session));
subversion/libsvn_ra_serf/update.c: return
svn_error_create(SVN_ERR_RA_SERF_WRAPPED_ERROR, err, NULL);
subversion/libsvn_ra_serf/util.c: return
svn_error_create(SVN_ERR_RA_SERF_SSL_CERT_UNTRUSTED, NULL, NULL);
subversion/libsvn_ra_serf/util.c: err =
svn_error_create(SVN_ERR_RA_SERF_WRAPPED_ERROR, err, NULL);
subversion/libsvn_ra_serf/util.c: err =
svn_error_create(SVN_ERR_RA_SERF_WRAPPED_ERROR, err, NULL);
subversion/libsvn_ra_serf/util.c: err =
svn_error_create(SVN_ERR_RA_SERF_WRAPPED_ERROR, err, NULL);
subversion/libsvn_ra_serf/util_error.c: err =
svn_error_create(SVN_ERR_RA_SERF_WRAPPED_ERROR, err, NULL);
% grep 'SVN_ERR.*SERF' subversion/*{ra,client} | wc -l
0
%
