Philip Martin wrote on Wed, May 22, 2013 at 10:44:33 +0100: > Philip Martin <[email protected]> writes: > > > My first loop results in a final trailing " " and my second loop results > > in a leading " ". Perhaps: > > > > const char *failed_command = cmd[0]; > > for (i = 1; cmd[i]; ++i) > > failed_command = apr_psprintf(pool, "%s %s", failed_command, > > cmd[i]); > > Another problem is that you go on to do: > > return svn_error_createf(SVN_ERR_EXTERNAL_PROGRAM, NULL, > _("'%s' was expanded to '%s' and returned %d"), > external_diff_cmd, > svn_dirent_local_style(failed_command, pool), > *pexitcode); > > which applies local style to the whole command string not just to paths. > On Windows that will convert all '/' to '\' and command options on > Windows can use '/' where Unix would use '-'.
I pointed out this issue already in my branch review.
